[experimental] add SSL support for HTTP server configuration#6295
Merged
ar2rsawseen merged 5 commits intomasterfrom Jun 19, 2025
Merged
[experimental] add SSL support for HTTP server configuration#6295ar2rsawseen merged 5 commits intomasterfrom
ar2rsawseen merged 5 commits intomasterfrom
Conversation
kanwarujjaval
requested review from
a team,
ArtursKadikis,
John-Weak,
ar2rsawseen,
Copilot,
pnrgenc and
widatama
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds experimental SSL support for both the HTTP and API server configurations. The changes include new SSL configuration options, updates to the server setup logic to conditionally use HTTPS, and corresponding updates in configuration sample files.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/express/config.sample.js | Added SSL configuration options for the Express web server. |
| frontend/express/app.js | Updated server initialization to support SSL with HTTPS server. |
| api/config.sample.js | Added SSL configuration options for the API server. |
| api/api.js | Updated API server initialization to support SSL and HTTPS server. |
Comments suppressed due to low confidence (1)
frontend/express/app.js:1944
- The 'fs' module is used to read SSL files but is not imported in this file. Please add
const fs = require('fs');at the top to avoid runtime errors when SSL is enabled.
key: fs.readFileSync(countlyConfig.web.ssl.key),
ar2rsawseen
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.